Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Upgrade giovanni to 0.22.0 #24213

Closed
wants to merge 9 commits into from
Closed

internal: Upgrade giovanni to 0.22.0 #24213

wants to merge 9 commits into from

Conversation

favoretti
Copy link
Collaborator

No description provided.

tombuildsstuff
tombuildsstuff reviewed Dec 13, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@favoretti favoretti force-pushed the favoretti/giovanni_upgrade branch from 34db6e6 to 6d3f6ae Compare December 14, 2023 09:52
@tombuildsstuff
Copy link
Contributor

Dependent on tombuildsstuff/giovanni#98

@tombuildsstuff tombuildsstuff mentioned this pull request Dec 14, 2023
Merged
@favoretti favoretti changed the title internal: Upgrade giovanni to 0.21.0 internal: Upgrade giovanni to 0.22.0 Dec 14, 2023
tombuildsstuff
tombuildsstuff reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few notes around TODOs inline

internal/services/storage/client/client.go Show resolved Hide resolved
internal/services/storage/client/client.go Show resolved Hide resolved
internal/services/storage/client/client.go Show resolved Hide resolved
@favoretti favoretti force-pushed the favoretti/giovanni_upgrade branch from 2d57932 to aa7b686 Compare December 21, 2023 15:33
@favoretti favoretti force-pushed the favoretti/giovanni_upgrade branch from 0569d97 to 6cb410d Compare January 19, 2024 09:46
@tombuildsstuff tombuildsstuff mentioned this pull request Jan 23, 2024
Closed
1 task
@katbyte katbyte mentioned this pull request Feb 16, 2024
Merged
9 tasks
@github-actions GitHub Actions
Copy link

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

@github-actions github-actions bot added the stale label Feb 19, 2024
@katbyte
Copy link
Collaborator

katbyte commented Feb 20, 2024

@favoretti i'm going to close this out in favour of #24798 which should be merged soon!

@katbyte katbyte closed this Feb 20, 2024
@github-actions github-actions bot removed the stale label Feb 20, 2024
@favoretti
Copy link
Collaborator Author

@katbyte yeah, absolutely, so sorry, I am completely swamped at work, I have hoped to have this finished long time ago, but I can't spare any cycles tight now.

@manicminer
Copy link
Contributor

@favoretti No worries at all! This was quite a heavy upgrade in the end anyway 🙂

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

Assignees
No one assigned
Labels
dependencies service/storage size/XL state-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@favoretti @tombuildsstuff @katbyte @manicminer